[webkit-reviews] review granted: [Bug 38151] drop support for sessionStorage in sandbox iframes : [Attachment 55170] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38151: drop support for sessionStorage in sandbox iframes
https://bugs.webkit.org/show_bug.cgi?id=38151

Attachment 55170: Patch
https://bugs.webkit.org/attachment.cgi?id=55170&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore/storage/StorageEventDispatcher.cpp:60
 +		if (!ec)
Could/should this be an early return instead of further indent to the
line-that-never-wrapped?

WebCore/storage/StorageEventDispatcher.cpp:61
 +		   
frames[i]->document()->enqueueEvent(StorageEvent::create(eventNames().storageEv
ent, key, oldValue, newValue, sourceFrame->document()->url(), storage));
I'm rather anti-wrap, but I think even I might have used a local variable here.


WebKit/chromium/src/StorageAreaProxy.cpp:130
 +		Storage* storage = frames[i]->domWindow()->sessionStorage(ec);
Why not just check storage != NULL?

Seems OK, even if the EC handling is slightly inelegant.