[webkit-reviews] review requested: [Bug 33805] Must implement OpenGL ES 2.0 semantics for NPOT textures : [Attachment 55191] revised patch: responding to Gregg Tavares comments

[bugzilla-daemon at webkit.org]

Zhenyao Mo <zmo at google.com> has asked  for review:
Bug 33805: Must implement OpenGL ES 2.0 semantics for NPOT textures
https://bugs.webkit.org/show_bug.cgi?id=33805

Attachment 55191: revised patch: responding to Gregg Tavares comments
https://bugs.webkit.org/attachment.cgi?id=55191&action=review

------- Additional Comments from Zhenyao Mo <zmo at google.com>
The following comments are from Gregg Tavares:

"""
at line 773 you only check m_activeTextureUnit.  You actually have to loop over
all the texture units as in

for (GLint ii = 0; ii < max_active_texture_units; ++ii) {
  RefPtr<WebGLTexture> tex2D = m_textureUnits[ii].m_texture2DBinding;

Then, if the texture needs binding you have to call glActiveTexture to make
that the active texture unit before you call glBindTexture

Finally, after you call glDraw and you have to loop again, restore all the
textures with a similar loop and finally call glActiveTexture to set it back to
what it was before you entered this function.
"""