[webkit-reviews] review granted: [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player : [Attachment 55057] Part 2: QTMovieWin: New Classes QTPixelBuffer, QTCFDictionary, and QTMovieVisualContext

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 34005: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005

Attachment 55057: Part 2: QTMovieWin: New Classes QTPixelBuffer,
QTCFDictionary, and QTMovieVisualContext
https://bugs.webkit.org/attachment.cgi?id=55057&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
WebCore/platform/graphics/win/QTMovieVisualContext.cpp:76
 +	    pPixelBufferContextCreate =
reinterpret_cast<pfnQTPixelBufferContextCreate>(GetProcAddress(qtmlDLL,
"QTPixelBufferContextCreate"));
Add :: to the GetProcAddress call like you did with LoadLibraryW.

WebCore/platform/graphics/win/QTPixelBuffer.cpp:68
 +	m_pixelBuffer = ref;
If you want to, you could return early if ref == m_pixelBuffer.

(I don't feel strongly about it though).


Looks great otherwise, r=me!