[webkit-reviews] review granted: [Bug 38565] REGRESSION: composited iframe contents no longer visible after r58797 : [Attachment 55174] Patch with pixel test

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 38565: REGRESSION: composited iframe contents no longer visible after
r58797
https://bugs.webkit.org/show_bug.cgi?id=38565

Attachment 55174: Patch with pixel test
https://bugs.webkit.org/attachment.cgi?id=55174&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 58844)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,18 @@
> +2010-05-05  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Got composited iframes showing up on Mac again
> +	   https://bugs.webkit.org/show_bug.cgi?id=38565

This should have a bit more verbage saying when it regressed, and what you did
to fix it.

> Index: LayoutTests/compositing/iframes/composited-iframe-alignment.html
> ===================================================================

> +  <script type="text/javascript" charset="utf-8">
> +    //if (window.layoutTestController) {
> +    //    layoutTestController.dumpAsText();
> +	   layoutTestController.waitUntilDone();
> +    //}

Why the commented out lines?

> +    <!-- The parent document should be thrown into compositing mode by the
iframe. -->

That's not true on Mac.

r=me with a better changelog and test cleanup.