[webkit-reviews] review requested: [Bug 38603] Expose the editing behavior setting in DRT to test all editing code paths : [Attachment 55171] Expose the editing behavior setting to DRT

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 16:29:05 PDT 2010


Martin Robinson <mrobinson at webkit.org> has asked  for review:
Bug 38603: Expose the editing behavior setting in DRT to test all editing code
paths
https://bugs.webkit.org/show_bug.cgi?id=38603

Attachment 55171: Expose the editing behavior setting to DRT
https://bugs.webkit.org/attachment.cgi?id=55171&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
I've attached a rough patch for this. A couple notes:

1. I've implemented the necessary API points and DRT support for Windows/Mac,
GTK+ and Chromium ports. This is my first shot at mucking with some of these
ports so the style/implementation might be wrong. Qt and Wx are just stubbed
out right now. I don't see LayoutTestController implementations for EFL or
Haiku.

2. I've only converted one test because fixing this bug is the bootstrapping
phase of fixing many GTK+ selection and DRT bugs. The test I converted is only
1 patch away from passing on GTK+, so it's a good starting point. I plan to
iteratively convert tests as I fix bugs on GTK+.


More information about the webkit-reviews mailing list