[webkit-reviews] review requested: [Bug 38598] Failed at http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.transformation.html : [Attachment 55141] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 12:20:24 PDT 2010


qi <qi.2.zhang at nokia.com> has asked  for review:
Bug 38598: Failed at
http://philip.html5.org/tests/canvas/suite/tests/2d.path.arcTo.transformation.h
tml
https://bugs.webkit.org/show_bug.cgi?id=38598

Attachment 55141: patch
https://bugs.webkit.org/attachment.cgi?id=55141&action=review

------- Additional Comments from qi <qi.2.zhang at nokia.com>
Due to QPainterPath.isEmpty "Returns true if either there are no elements in
this path, or if the only element is a MoveToElement; otherwise returns
false.", when QTransform try to transform a QPainterPath, if the path only have
MoveToElement, it will not transform actually.

In this case, the translation function happen after moveto, then the start
pointer didn't tranformed.

ctx.fillStyle = '#0f0';
ctx.beginPath();
ctx.moveTo(0, 50);
ctx.translate(100, 0);
ctx.arcTo(50, 50, 50, 0, 50);
ctx.lineTo(-100, 0);
ctx.fill();


More information about the webkit-reviews mailing list