[webkit-reviews] review denied: [Bug 38448] Web Inspector: Should Autocomplete Style Properties : [Attachment 54905] [PATCH] Proposed Fix

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 38448: Web Inspector: Should Autocomplete Style Properties
https://bugs.webkit.org/show_bug.cgi?id=38448

Attachment 54905: [PATCH] Proposed Fix
https://bugs.webkit.org/attachment.cgi?id=54905&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/InjectedScript.js:133
 +	    propertyNames =
propertyNames.concat(InjectedScript._hiddenStyleProperties);
Be careful, _getPropertyNames above already has style properties due to your
changes to InjectedScript._getPropertyNames.

In fact, if we are talking about autocomplete, you should only modify
InjectedScript.getCompletions. Otherwise, style objects start containing weird
properties in the object trees.