[webkit-reviews] review granted: [Bug 38157] Implement FileReader class : [Attachment 54831] Proposed Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 38157: Implement FileReader class
https://bugs.webkit.org/show_bug.cgi?id=38157

Attachment 54831: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=54831&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  Please address the comments below before landing.

WebCore/html/FileReader.cpp:173
 +	    m_result += String(data, static_cast<unsigned>(bytesRead));
Is this slow?  Should use use a StringBuilder or a SegmentedString instead?

WebCore/html/FileReader.cpp:256
 +	    if (m_rawData.size() >= 2 && m_rawData[0] == '\xFE' && m_rawData[1]
== '\xFF') {
Yuck.  Is this in the spec?  We should move this to a more generic location.

WebCore/html/FileReader.cpp:270
 +	// FIXME: consider upporting incremental decoding to improve the perf.
supporting

WebCore/html/FileReader.cpp:284
 +	m_result += "base64,";
Is "data:base64,..." a valid data URL?