[webkit-reviews] review canceled: [Bug 38587] @namespaces rules before @import rules are not invalidated : [Attachment 55126] proposed fix #1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed May 5 09:16:06 PDT 2010
Daniel Glazman <daniel at glazman.org> has canceled review:
Bug 38587: @namespaces rules before @import rules are not invalidated
https://bugs.webkit.org/show_bug.cgi?id=38587
Attachment 55126: proposed fix #1
https://bugs.webkit.org/attachment.cgi?id=55126&action=review
------- Additional Comments from Daniel Glazman <daniel at glazman.org>
(In reply to comment #1)
> (From update of attachment 55126 [details])
> Patch is lacking a changelog and testcase, so it's not ready for review, but
> thanks for the code changes Daniel!
I think the patch is in fact wrong. I ended up implementing the fix the wrong
way because the test in the Test Suite is not really testing the invalidity
of a @namespace but only the invalidity of an @import following a @namespace...
Revamping, stay tuned.
More information about the webkit-reviews
mailing list