[webkit-reviews] review requested: [Bug 38587] @namespaces rules before @import rules are not invalidated : [Attachment 55126] proposed fix #1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 08:11:43 PDT 2010


Daniel Glazman <daniel at glazman.org> has asked  for review:
Bug 38587: @namespaces rules before @import rules are not invalidated
https://bugs.webkit.org/show_bug.cgi?id=38587

Attachment 55126: proposed fix #1
https://bugs.webkit.org/attachment.cgi?id=55126&action=review

------- Additional Comments from Daniel Glazman <daniel at glazman.org>
Per CSS 3 Namespaces spec [1], @namespace rules must follow all @charset and
@import rules. This is not enforced at this time by CSSParser, and that's one
of the last tests from the Namespaces Test Suite WebKit fails [2].

I have written a patch to fix this bug. Please excuse me in advance if it does
not strictly follow WebKit coding style rules or misses an important
architectural step: this is my very first patch in WebKit...

[1] http://www.w3.org/TR/css3-namespace/#syntax
[2] http://www.w3.org/Style/CSS/Test/CSS3/Namespace/20090210/syntax-006.xml


More information about the webkit-reviews mailing list