[webkit-reviews] review requested: [Bug 38567] Web Inspector: FontView needs Cleanup : [Attachment 55093] [PATCH] Proposed Fix - FontView Cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed May 5 00:25:29 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 38567: Web Inspector: FontView needs Cleanup
https://bugs.webkit.org/show_bug.cgi?id=38567

Attachment 55093: [PATCH] Proposed Fix - FontView Cleanup
https://bugs.webkit.org/attachment.cgi?id=55093&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
The patch looks a lot scarier then it actually is.

- moved some code down from the constructor to contentTabSelected
- changed some variables to const for clarity
- cached the number of lines in this._lineCount (we may need to remove this if
we allow the users to edit the text on the fly! see bug 16232!)


More information about the webkit-reviews mailing list