[webkit-reviews] review granted: [Bug 38542] Web Inspector: Clickable links to resources should be used as 'details' part for the all suitable kinds of records. : [Attachment 55042] [patch] Initial version.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 38542: Web Inspector: Clickable links to resources should be used as
'details' part for the all suitable kinds of records.
https://bugs.webkit.org/show_bug.cgi?id=38542

Attachment 55042: [patch] Initial version.
https://bugs.webkit.org/attachment.cgi?id=55042&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
WebCore/inspector/front-end/TimelinePanel.js:1002
 +  WebInspector.TimelinePanel.FormattedRecord.PopupContentHelper =
function(title)
This could be WebInspector.TimelinePanel.PopupContentHelper or
WebInspector.TimelinePopupContentHelper. No need to create nesting that deep.
Same for FromattedRecord itself.

Please fix before landing!