[webkit-reviews] review requested: [Bug 38503] Remove all custom DB callbacks in favor of auto-generated callbacks : [Attachment 55068] patch

[bugzilla-daemon at webkit.org]

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 38503: Remove all custom DB callbacks in favor of auto-generated callbacks
https://bugs.webkit.org/show_bug.cgi?id=38503

Attachment 55068: patch
https://bugs.webkit.org/attachment.cgi?id=55068&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Should fix the GTK bot problem.

(In reply to comment #5)
> (From update of attachment 55006 [details])
> +  * Copyright (C) 2007 Apple Inc. All rights reserved.
> 
> Apple?

Oops, fixed. I assume you're referring to the new IDL files?

> + $implIncludes{"JS${type}.h"} = 1;
> 
> This is ugly.

Not sure how to handle this better. Most generated code needs to include
${type}.h, and callbacks need to include JS${type}.h for the toJS() function.