[webkit-reviews] review requested: [Bug 34005] Safari pegs CPU and drops tons of frames using HTML5 Vimeo player : [Attachment 55053] Part 1.1: QTMovieWin: The breakup of QTMovieWin
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 4 15:28:12 PDT 2010
Jer Noble <jer.noble at apple.com> has asked for review:
Bug 34005: Safari pegs CPU and drops tons of frames using HTML5 Vimeo player
https://bugs.webkit.org/show_bug.cgi?id=34005
Attachment 55053: Part 1.1: QTMovieWin: The breakup of QTMovieWin
https://bugs.webkit.org/attachment.cgi?id=55053&action=review
------- Additional Comments from Jer Noble <jer.noble at apple.com>
Sam, I addressed your comments in this patch, except for the DEFINE_STATIC
change. That I left out because I could not find a way to declare a static
non-const pointer with that macro. Also, it appeared that the macro in
question was designed to avoid file-level static initializers, and this static
is function level. If you want, I can still use the DEFINE_STATIC macro, and
const_cast away the constness of the static variable before returning it.
More information about the webkit-reviews
mailing list