[webkit-reviews] review granted: [Bug 38549] [WebKit2] The web process doesn't need to paint when the web view is hidden. : [Attachment 55050] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 38549: [WebKit2] The web process doesn't need to paint when the web view is
hidden.
https://bugs.webkit.org/show_bug.cgi?id=38549

Attachment 55050: Patch
https://bugs.webkit.org/attachment.cgi?id=55050&action=review

------- Additional Comments from mitz at webkit.org
> +void DrawingAreaUpdateChunk::suspendPainting()
> +{
> +    ASSERT(m_shouldPaint);

Do you really want to assert this?

> +void DrawingAreaUpdateChunk::resumePainting()
> +{
> +    ASSERT(!m_shouldPaint);

Do you really want to assert this?

r=me if you change “paint” to “update” and “painting” to “updating”.