[webkit-reviews] review denied: [Bug 38220] [chromium] Add API for querying whether a WebWidget is using GPU accelerated compositing : [Attachment 55033] patch. Modified to address review comments
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 4 14:16:07 PDT 2010
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 38220: [chromium] Add API for querying whether a WebWidget is using GPU
accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=38220
Attachment 55033: patch. Modified to address review comments
https://bugs.webkit.org/attachment.cgi?id=55033&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
sorry, more of the same kind of issue:
WebKit/chromium/src/WebViewImpl.h:188
+ virtual bool isAcceleratedCompositingActive() const;
this should be in the WebWidget section
WebKit/chromium/src/WebViewImpl.cpp:2054
+ bool WebViewImpl::isAcceleratedCompositingActive() const
this should be inserted after setTextDirection so that method
implementations are listed in the same order that they are
declared in the header and grouped by interface.
More information about the webkit-reviews
mailing list