[webkit-reviews] review granted: [Bug 38503] Remove all custom DB callbacks in favor of auto-generated callbacks : [Attachment 55006] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue May 4 13:56:16 PDT 2010
Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 38503: Remove all custom DB callbacks in favor of auto-generated callbacks
https://bugs.webkit.org/show_bug.cgi?id=38503
Attachment 55006: patch
https://bugs.webkit.org/attachment.cgi?id=55006&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This change is fantastic. Please make sure it builds on Gtk before committing.
+ * Copyright (C) 2007 Apple Inc. All rights reserved.
Apple?
+ $implIncludes{"JS${type}.h"} = 1;
This is ugly.
More information about the webkit-reviews
mailing list