[webkit-reviews] review denied: [Bug 38530] SVG fonts may create blank Glyph Cache Pages : [Attachment 55029] [PATCH] Proposed Fix - Test for SVG Fonts in initializePage

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Joseph Pecoraro <joepeck at webkit.org>'s request for
review:
Bug 38530: SVG fonts may create blank Glyph Cache Pages
https://bugs.webkit.org/show_bug.cgi?id=38530

Attachment 55029: [PATCH] Proposed Fix - Test for SVG Fonts in initializePage
https://bugs.webkit.org/attachment.cgi?id=55029&action=review

------- Additional Comments from mitz at webkit.org
I don’t think this is the best fix. SegmentedFontData::isSVGFont()—and by
extension FontData::isSVGFont()— doesn’t make sense. Even though currently SVG
segments aren’t handled correctly due to bug 32227, introducing this concept is
a step in the wrong direction. Instead, GlyphPageTreeNode::initializePage()
should examine individual SimpleFontData for SVG-ness, and in the SVG case,
instead of calling fill() it should zero-fill and behave as if fill() returned
false. Since fill() has two call sites in initializePage(), you can add a small
static helper method that does this.