[webkit-reviews] review denied: [Bug 38220] [chromium] Add API for querying whether a WebWidget is using GPU accelerated compositing : [Attachment 54969] Patch - fixed style issue

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 11:05:51 PDT 2010


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 38220: [chromium] Add API for querying whether a WebWidget is using GPU
accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=38220

Attachment 54969: Patch - fixed style issue
https://bugs.webkit.org/attachment.cgi?id=54969&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
WebKit/chromium/public/WebPopupMenu.h:44
> +	 virtual bool isAcceleratedCompositingActive() const = 0;
You can delete this line as WebPopupMenu inherits from WebWidget.

WebKit/chromium/src/WebPopupMenuImpl.h:82
> +	 virtual bool isAcceleratedCompositingActive() const { return false; }
please create a separate section labelled WebPopupMenu and move this
method there.

the method declarations are grouped by interfaces being implemented.

otherwise, LGTM!


More information about the webkit-reviews mailing list