[webkit-reviews] review granted: [Bug 38525] JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include jni_jsobject.h for jlong_to_pt() and ptr_to_jlong() : [Attachment 55024] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 10:25:22 PDT 2010


Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 38525: JavaInstanceJSC.cpp and JNIUtilityPrivate.cpp need to include
jni_jsobject.h for jlong_to_pt() and ptr_to_jlong()
https://bugs.webkit.org/show_bug.cgi?id=38525

Attachment 55024: Patch
https://bugs.webkit.org/attachment.cgi?id=55024&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>  #define jlong_to_impptr(a)
(static_cast<JSC::JSObject*>(((void*)(uintptr_t)(a))))
>  #define ptr_to_jlong(a) ((jlong)(uintptr_t)(a))
>  
> +#if PLATFORM(MAC)
> +
> +#include <CoreFoundation/CoreFoundation.h>

Normally in WebKit, conditional includes go up at the top of the file with the
other includes, not down below things like macros. I also think this include is
unneeded.

r=me


More information about the webkit-reviews mailing list