[webkit-reviews] review denied: [Bug 37743] Remove dependency of jsCurrentTime() on currentTime() : [Attachment 54996] A bigger patch which rename the corresponding functions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 10:19:35 PDT 2010


Darin Adler <darin at apple.com> has denied Leo Yang
<leo.yang at torchmobile.com.cn>'s request for review:
Bug 37743: Remove dependency of jsCurrentTime() on currentTime()
https://bugs.webkit.org/show_bug.cgi?id=37743

Attachment 54996: A bigger patch which rename the corresponding functions
https://bugs.webkit.org/attachment.cgi?id=54996&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems to break the build on every platform.

Maybe you could break this up into multiple patches. One could change the calls
at all the call sites and so be entirely mechanical.

The part of this that needs careful review is that we have to figure out at
each call site if it's OK to use the monotonic time rather than the clock time.
It would be good to review those carefully a few at a time instead of in a
single giant patch. Perhaps the first patch would be to convert all the call
sites where it's very clear and completely obvious which to use.


More information about the webkit-reviews mailing list