[webkit-reviews] review granted: [Bug 38470] Add first WTFURL file : [Attachment 55000] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue May 4 00:54:24 PDT 2010


Maciej Stachowiak <mjs at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 38470: Add first WTFURL file
https://bugs.webkit.org/show_bug.cgi?id=38470

Attachment 55000: Patch
https://bugs.webkit.org/attachment.cgi?id=55000&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
JavaScriptCore/wtf/url/src/URLComponent.h:66
 +	int m_length; // Will be -1 if the component is unspecified.
I'm not a fan of in-band signalling like this. It tends to be error-prone. Is
the size of this class critical? In any case, I guess it's fine to initially
land like this.

r=me


More information about the webkit-reviews mailing list