[webkit-reviews] review granted: [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs : [Attachment 54994] [PATCH] Clip like text input

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Joseph Pecoraro <joepeck at webkit.org>'s request for
review:
Bug 38468: REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468

Attachment 54994: [PATCH] Clip like text input
https://bugs.webkit.org/attachment.cgi?id=54994&action=review

------- Additional Comments from mitz at webkit.org
r=me

I can’t help commenting on something:

> +    ASSERT(m_innerBlock);
> +
> +    IntRect clipRect = IntRect(m_innerBlock->renderBox()->frameRect());

In my opinion, asserting that a pointer is not null is pointless if you are
immediately going to dereference the pointer—you will crash anyway and you’ll
be able to tell why. But maybe others think differently.