[webkit-reviews] review granted: [Bug 36818] [Qt] Animated GIF images does not animate 10x as expected by default. : [Attachment 54802] patch file

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Jay Tucker
<jay.tucker at nokia.com>'s request for review:
Bug 36818: [Qt] Animated GIF images does not animate 10x as expected by
default.
https://bugs.webkit.org/show_bug.cgi?id=36818

Attachment 54802: patch file
https://bugs.webkit.org/attachment.cgi?id=54802&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> ===================================================================
> --- WebCore/platform/graphics/qt/ImageDecoderQt.cpp	(revision 58574)
> +++ WebCore/platform/graphics/qt/ImageDecoderQt.cpp	(working copy)
> @@ -123,12 +123,14 @@ int ImageDecoderQt::repetitionCount() co
>	   //  Qt   |	WebCore 	 | description
>	   //  -1   |	  0		 | infinite animation
>	   //	0   | cAnimationLoopOnce | show every frame once
> -	   //	n   |	  n		 | no idea if that is supported
> +	   //	n   |	  n+1		 | Qt returns the # of iterations - 1

Okay, as a follow up patch for Qt. Could you verify that MNG and GIF behave the
same in Qt? In the past I was adding unit tests to Qt to verify the Qt column.
I could not test loop n-times as GIMP didn't allow to save an image like this.