[webkit-reviews] review denied: [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs : [Attachment 54984] [PATCH] Proposed Fix Based on My Comments

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Joseph Pecoraro <joepeck at webkit.org>'s request for
review:
Bug 38468: REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468

Attachment 54984: [PATCH] Proposed Fix Based on My Comments
https://bugs.webkit.org/attachment.cgi?id=54984&action=review

------- Additional Comments from mitz at webkit.org
> +    IntRect clipRect = IntRect(renderBox->x(), max(borderTop() +
paddingTop(), renderBox->y()), contentWidth(), contentHeight());	

Wouldn’t this lead to asymmetry between the case of (top padding with no bottom
padding) and (bottom padding with no top padding)?

Anyway, looking at this again, and comparing with the behavior of <input
type="text">, which uses overflow: hidden on the text block in order to clip
(this is why it doesn’t need to have control clip), I now think that the case I
last mentioned is not worth preserving, and that one should just clip to the
inner block, which would be consistent with text fields.