[webkit-reviews] review granted: [Bug 38496] [WebKit2] WKView should respond to WM_SHOWWINDOW messages : [Attachment 54975] Patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 38496: [WebKit2] WKView should respond to WM_SHOWWINDOW messages
https://bugs.webkit.org/show_bug.cgi?id=38496

Attachment 54975: Patch
https://bugs.webkit.org/attachment.cgi?id=54975&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> Index: WebKit2/ChangeLog
> ===================================================================
> --- WebKit2/ChangeLog (revision 58716)
> +++ WebKit2/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2010-05-03  Anders Carlsson	<andersca at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [WebKit2] WKView should respond to WM_SHOWWINDOW messages
> +	   https://bugs.webkit.org/show_bug.cgi?id=38496
> +
> +	   * UIProcess/win/WebView.cpp:
> +	   (WebKit::WebView::wndProc):
> +	   Add case for WM_SHOWWINDOW.
> +
> +	   (WebKit::WebView::onShowWindowEvent):
> +	   Update the page visibility.accordingly.
Typo.

>  
> +LRESULT WebView::onShowWindowEvent(HWND hWnd, UINT message, WPARAM wParam,
LPARAM lParam, bool& handled)
> +{
> +    // lParam is 0 when the message is sent because of a ShowWindow call.
> +    if (!lParam) {
> +	   bool isVisible = wParam;
> +
> +	   // Notify the drawing area that the visibility changed.
> +	   m_page->drawingArea()->setPageIsVisible(isVisible);

What happens if you call ShowWindow on a WKView that is the child of a hidden
window? Does it still receive WM_SHOWWINDOW? Do you want to set "page is
visible" in that case? 

r=me