[webkit-reviews] review requested: [Bug 38468] REGRESSION: Text clipped in absolutely positioned search inputs : [Attachment 54974] [PATCH] Quick Fix

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 38468: REGRESSION: Text clipped in absolutely positioned search inputs
https://bugs.webkit.org/show_bug.cgi?id=38468

Attachment 54974: [PATCH] Quick Fix
https://bugs.webkit.org/attachment.cgi?id=54974&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
This is just a quick fix to the issue. This matches RenderButton's
implementation. It is rect containing the contents (with padding but without
borders).

Dan Bernstein also raised a good question:

  I think the clip rect is essential for when the field height is less than the

  text height. I just don’t know why it isn’t applied to non-search fields
  just as well.

This patch does not address those issues, only fixing my mistake.

I could add a patch to this test, but I think this was just fixing the blunder
on my part. But, if a test is desired I could modify the attached test and add
another pixel test.