[webkit-reviews] review requested: [Bug 30457] Allow image requests started from unload handlers to outlive the page : [Attachment 54968] Attempt #7 (clean up weird layering)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 15:29:38 PDT 2010


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 30457: Allow image requests started from unload handlers to outlive the
page
https://bugs.webkit.org/show_bug.cgi?id=30457

Attachment 54968: Attempt #7 (clean up weird layering)
https://bugs.webkit.org/attachment.cgi?id=54968&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
In previous iterations, I was doing the check for whether we were loading an
image from an unload event handler in Loader::load().  This version exposes an
OutlivePagePolicy parameter on this function, so that the image-specific logic
can be in CachedImage::load().

This also makes things more generic, in particular giving us the option of
adding other loads that occur asynchronously through navigation.


More information about the webkit-reviews mailing list