[webkit-reviews] review granted: [Bug 38414] Auto-generate the callbacks code : [Attachment 54963] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 38414: Auto-generate the callbacks code
https://bugs.webkit.org/show_bug.cgi?id=38414

Attachment 54963: patch
https://bugs.webkit.org/attachment.cgi?id=54963&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Okiedokes!

WebCore/bindings/scripts/CodeGeneratorJS.pm:525
 +  sub GenerateHeaderContentHeader
The pattern we prefer here is to return a local @code and have the caller push
it onto @headerContentHeader.  That way we have fewer mucking with global
variables.

WebCore/bindings/scripts/CodeGeneratorV8.pm:2218
 +	push(@implContent, <<END);
It's unclear when you decide to use this patter and when you use strings
directly.  I'm not sure it really matters, but we should aim for consistency in
the long term.

WebCore/bindings/scripts/CodeGeneratorV8.pm:2261
 +		@argvs = ();
my @argvs

WebCore/bindings/scripts/CodeGeneratorV8.pm:2761
 +  sub GetNativeTypeForCallbacks
This function continues to make me sad.  We should rationalize how this works
in the two generators someday.