[webkit-reviews] review denied: [Bug 38368] When FastMalloc Returns memory often left with lots of small spans : [Attachment 54841] patch with correct fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 14:47:42 PDT 2010


Geoffrey Garen <ggaren at apple.com> has denied Stephanie Lewis
<slewis at apple.com>'s request for review:
Bug 38368: When FastMalloc Returns memory often left with lots of small spans
https://bugs.webkit.org/show_bug.cgi?id=38368

Attachment 54841: patch with correct fix
https://bugs.webkit.org/attachment.cgi?id=54841&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think the "l" postfix is wrong, since it will give you a long where you want
a floating point number. The simplest way to appease the 64-bit warning is
probably to use float, since it's 32-bit.


More information about the webkit-reviews mailing list