[webkit-reviews] review requested: [Bug 38454] svn-apply: Have parseDiffHeader() call parseGitDiffHeader(). : [Attachment 54959] Proposed patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 14:07:09 PDT 2010


Chris Jerdonek <cjerdonek at webkit.org> has asked  for review:
Bug 38454: svn-apply: Have parseDiffHeader() call parseGitDiffHeader().
https://bugs.webkit.org/show_bug.cgi?id=38454

Attachment 54959: Proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=54959&action=review

------- Additional Comments from Chris Jerdonek <cjerdonek at webkit.org>
A minor change to the ChangeLog and a code comment.

By the way, expect style errors for tabs in this patch.  This is because diffs
contain tab characters, and the unit tests contain sample diffs.

Also marking cq- since this patch will require setting the svn:allow-tabs
property.


More information about the webkit-reviews mailing list