[webkit-reviews] review granted: [Bug 38483] Implement PageClient::isPageVisible on Windows. : [Attachment 54956] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon May 3 13:10:15 PDT 2010
Adam Roben (aroben) <aroben at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 38483: Implement PageClient::isPageVisible on Windows.
https://bugs.webkit.org/show_bug.cgi?id=38483
Attachment 54956: Patch
https://bugs.webkit.org/attachment.cgi?id=54956&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Is it possible for m_window to be null?
The FIXME seems incorrect if it's possible for m_window to be a top-level
window.
You could add a FIXME about checking if the window is clipped out of view.
r=me
More information about the webkit-reviews
mailing list