[webkit-reviews] review requested: [Bug 38146] document.write is not synchronous : [Attachment 54934] [PATCH] Addressed Comments - Added Test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 09:46:19 PDT 2010


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 38146: document.write is not synchronous
https://bugs.webkit.org/show_bug.cgi?id=38146

Attachment 54934: [PATCH] Addressed Comments - Added Test
https://bugs.webkit.org/attachment.cgi?id=54934&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
> 1) it would probably be good to mention the external script exception to
> synchronous behavior in the ChangeLog

Sure, I've added a comment to the code as well as the ChangeLog.


> 2) it would be good to add a test case, even if it only  fails part of the
time
> in the bad case, or even if it is a manual test

I added a LayoutTest in fast/dom since I'm told "fast" is a misnomer. This
isn't really a fast test.


More information about the webkit-reviews mailing list