[webkit-reviews] review granted: [Bug 37500] [Gtk] Fix leaking the FontPlatformData instance used to create the the small caps font data. : [Attachment 53243] Patch to fix the problem

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Stephan Aßmus
<superstippi at gmx.de>'s request for review:
Bug 37500: [Gtk] Fix leaking the FontPlatformData instance used to create the
the small caps font data.
https://bugs.webkit.org/show_bug.cgi?id=37500

Attachment 53243: Patch to fix the problem
https://bugs.webkit.org/attachment.cgi?id=53243&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 57513)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,18 @@
> +2010-04-13  Stephan Aßmus  <superstippi at gmx.de>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Gtk] Fix leaking the FontPlatformData instance used to create the
the
> +	   small caps font data.
> +	   https://bugs.webkit.org/show_bug.cgi?id=37500
> +
> +	   No new tests needed.
> +
> +	   * platform/graphics/gtk/SimpleFontDataPango.cpp:
> +	   (WebCore::SimpleFontData::smallCapsFontData):
> +	       - Use a stack allocated FontPlatformData instead of a heap
allocated
> +		 one that is never freed.

Thanks a lot!