[webkit-reviews] review denied: [Bug 37851] [GTK] Does not compile with -DGSEAL_ENABLE : [Attachment 54144] Partial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon May 3 06:20:05 PDT 2010


Holger Freyther <zecke at selfish.org> has denied Andre Klapper
<a9016009 at gmx.de>'s request for review:
Bug 37851: [GTK] Does not compile with -DGSEAL_ENABLE
https://bugs.webkit.org/show_bug.cgi?id=37851

Attachment 54144: Partial patch
https://bugs.webkit.org/attachment.cgi?id=54144&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Sorry for waiting so letting you wait so long. We want to avoid the #if
GTK_CHECK_VERSION, what we do  is to add a macro in
WebCore/platform/gtk/GtkVersioning.h and this way can use the new API on old
systems. It would be nice if you could adjust your patch.


More information about the webkit-reviews mailing list