[webkit-reviews] review denied: [Bug 38434] Use HTML5 number parsing in HTMLProgressElement : [Attachment 54878] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 38434: Use HTML5 number parsing in HTMLProgressElement
https://bugs.webkit.org/show_bug.cgi?id=38434

Attachment 54878: Patch
https://bugs.webkit.org/attachment.cgi?id=54878&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Use parseToDoubleForNumberType instead of toDouble.

Where are the tests for the behavior changes this creates? We require tests for
any bug fixes. Or is this refactoring only?

> +	   Throw an exception when the number is NaN or Infinity.

All the test changes seem to be for this independent half of the patch.

> +    if (isnan(value) || !isfinite(value)) {

The isnan check here is redundant and should be removed. The isfinite function
returns false for NAN.

review- because of a lack of test for the HTML5 number parsing change and
because the extra check should be omitted.