[webkit-reviews] review granted: [Bug 38445] REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset() : [Attachment 54901] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 38445: REGRESSION: Infinite recursion in Position::getInlineBoxAndOffset()
https://bugs.webkit.org/show_bug.cgi?id=38445

Attachment 54901: Patch
https://bugs.webkit.org/attachment.cgi?id=54901&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================

> +	   possible, crossing any editability boudaries. Infinite recursion is
avoided by advancing all the way

Typo: "boudaries"

> Index: WebCore/dom/Position.cpp
> ===================================================================

> +static Position downstreamIgnoringEditingBoundaries(Position position)

Should this take a const Position&?

> +static Position upstreamIgnoringEditingBoundaries(Position position)

Ditto

WebCore/ChangeLog:18
 +	    test for buttons with the generic and more comprehensive
canHaveChildrenForEditing().

Does this part of the change need its own testcase?

r=me