[webkit-reviews] review granted: [Bug 38146] document.write is not synchronous : [Attachment 54345] [PATCH] Force Document.write to be Synchronous

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 38146: document.write is not synchronous
https://bugs.webkit.org/show_bug.cgi?id=38146

Attachment 54345: [PATCH] Force Document.write to be Synchronous
https://bugs.webkit.org/attachment.cgi?id=54345&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Code change looks good, but I have two suggestions for improving this patch:

1) it would probably be good to mention the external script exception to
synchronous behavior in the ChangeLog
2) it would be good to add a test case, even if it only  fails part of the time
in the bad case, or even if it is a manual test

r- for now for the lack of test. I'll gladly r+ if the points above are
addressed.