[webkit-reviews] review granted: [Bug 35163] autoinstall: should unzip downloaded zip and gzip files prior to importing : [Attachment 52240] Proposed patch 6
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 22:36:34 PDT 2010
David Levin <levin at chromium.org> has granted Chris Jerdonek
<cjerdonek at webkit.org>'s request for review:
Bug 35163: autoinstall: should unzip downloaded zip and gzip files prior to
importing
https://bugs.webkit.org/show_bug.cgi?id=35163
Attachment 52240: Proposed patch 6
https://bugs.webkit.org/attachment.cgi?id=52240&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/test-webkitpy
b/WebKitTools/Scripts/test-webkitpy.
> + if record.name.startswith("webkitpy.common.system.autoinstall") or \
> + record.name.startswith("webkitpy.test"):
I prefer using parenthesis for a case like this as opposed to the line
continuation \ (but this is very much a personal preference).
(Probably because I learned python while using this style guide:
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Line_len
gth#Line_length)
More information about the webkit-reviews
mailing list