[webkit-reviews] review requested: [Bug 35702] [Qt] Add more support for InputTextController : [Attachment 52196] Updated Patch - Needs a Look!

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 12:40:01 PDT 2010


Robert Hogan <robert at webkit.org> has asked  for review:
Bug 35702: [Qt] Add more support for InputTextController
https://bugs.webkit.org/show_bug.cgi?id=35702

Attachment 52196: Updated Patch - Needs a Look!
https://bugs.webkit.org/attachment.cgi?id=52196&action=review

------- Additional Comments from Robert Hogan <robert at webkit.org>
I've made a couple of modifications to cope with the test added to tst_qwepage
by Yi Shen. The first is in qwebpage itself, but I have also had to add a step
to tst_qwebpage where it cancels the current composition before performing the
negative selection. I believe this is correct but would like someone more
conversant with the expected behaviour of input methods (Yi Shen?) to take a
look first!


More information about the webkit-reviews mailing list