[webkit-reviews] review denied: [Bug 34979] [WinCairo, Windows] Implement COM wrappers for DOM traversal : [Attachment 52191] Proposed patch - implemented numerous methods in DOMCoreClasses.cpp and added classes for missing DOM objects.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 11:51:10 PDT 2010


Adam Roben (aroben) <aroben at apple.com> has denied Peter Nelson
<charn.opcode at gmail.com>'s request for review:
Bug 34979: [WinCairo, Windows] Implement COM wrappers for DOM traversal
https://bugs.webkit.org/show_bug.cgi?id=34979

Attachment 52191: Proposed patch - implemented numerous methods in
DOMCoreClasses.cpp and added classes for missing DOM objects.
https://bugs.webkit.org/attachment.cgi?id=52191&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Thanks for contributing this patch!

This patch is a bit too big to be reviewed in a timely manner. Could you please
break it up into smaller pieces that can each be reviewed and landed
independently?

You should also fix the errors that the style checker uncovered.


More information about the webkit-reviews mailing list