[webkit-reviews] review granted: [Bug 36892] [V8] SerializedScriptValue must be deserialized only once and in the right context : [Attachment 52190] patch v1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 11:34:59 PDT 2010
David Levin <levin at chromium.org> has granted Vitaly Repeshko
<vitalyr at chromium.org>'s request for review:
Bug 36892: [V8] SerializedScriptValue must be deserialized only once and in the
right context
https://bugs.webkit.org/show_bug.cgi?id=36892
Attachment 52190: patch v1
https://bugs.webkit.org/attachment.cgi?id=52190&action=review
------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebCore/bindings/scripts/CodeGeneratorV8.pm
b/WebCore/bindings/scripts/CodeGeneratorV8.pm
> + if ($serializedAttribute->type =~ /^readonly/) {
> + $attrAttr .= "|v8::ReadOnly";
Ideally add spaces around | (so the code will match the general WK style).
More information about the webkit-reviews
mailing list