[webkit-reviews] review granted: [Bug 36477] webkit-patch reads wrong bug url from unified diff context : [Attachment 52145] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 11:24:06 PDT 2010


Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 36477: webkit-patch reads wrong bug url from unified diff context
https://bugs.webkit.org/show_bug.cgi?id=36477

Attachment 52145: Patch
https://bugs.webkit.org/attachment.cgi?id=52145&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think it's right that commit_message_for_this_commit throws.  But
that's an old mistake of mine.	Would be nice to have a FIXME in your
try-catch, but this is fine as is.


More information about the webkit-reviews mailing list