[webkit-reviews] review granted: [Bug 36874] Cleanup RedirectScheduler : [Attachment 52144] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 36874: Cleanup RedirectScheduler
https://bugs.webkit.org/show_bug.cgi?id=36874

Attachment 52144: Patch
https://bugs.webkit.org/attachment.cgi?id=52144&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   Cleanup RedirectScheduler
> +	   https://bugs.webkit.org/show_bug.cgi?id=36874
> +
> +	  Removed the nutty ScheduledRedirection struct in favor of a hierarchy


^^^ bad indentation

otherwise, this all looks good to me.  given the naming of the file, it seems
like it would be nice if the base interface were named ScheduledRedirect, but
I realize why you chose not to do that.