[webkit-reviews] review granted: [Bug 36664] Add animation to progress element : [Attachment 52177] Patch updated based on comment #8.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 09:41:32 PDT 2010
Antti Koivisto <koivisto at iki.fi> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 36664: Add animation to progress element
https://bugs.webkit.org/show_bug.cgi?id=36664
Attachment 52177: Patch updated based on comment #8.
https://bugs.webkit.org/attachment.cgi?id=52177&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Nice, r=me
> + m_animationTimer.stop();
> + if (m_animating) {
> + m_animationStartTime = currentTime();
> + m_animationTimer.startOneShot(m_animationRepeatInterval);
> + }
That could be
else
m_animationTimer.stop();
(it is ok to start active timer again)
More information about the webkit-reviews
mailing list