[webkit-reviews] review granted: [Bug 36798] iframe flattening doesn't flatten : [Attachment 52172] Scrollbar related patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 36798: iframe flattening doesn't flatten
https://bugs.webkit.org/show_bug.cgi?id=36798

Attachment 52172: Scrollbar related patch
https://bugs.webkit.org/attachment.cgi?id=52172&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
r=me

> +bool FrameView::avoidScrollbarCreation()
> +{
> +    // with frame flattening no subframe can have scrollbars
> +    // but we also cannot turn scrollbars of as we determine
> +    // our flattening policy using that.
> +
> +    if (m_frame->page()->mainFrame() == m_frame)
> +	   false;
> +
> +    if (!m_frame->settings() ||
m_frame->settings()->frameFlatteningEnabled())
> +	   return true;

I suspect there no need to null test m_frame->setting().