[webkit-reviews] review denied: [Bug 36885] Web Inspector: [Chromium] inspector/audits-panel-functional.html crashes test_shell : [Attachment 52167] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 36885: Web Inspector: [Chromium] inspector/audits-panel-functional.html
crashes test_shell
https://bugs.webkit.org/show_bug.cgi?id=36885

Attachment 52167: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=52167&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>

> +    setTimeout(function() {evaluateInWebInspector("frontend_runAudits",
callback)}, 0);
>  }

This is a hack.

> +    testController.waitUntilDone();

Every wait should have notify.


To fix your problem, do not call layoutTestController's notifyDone upon first
return from the front-end.