[webkit-reviews] review denied: [Bug 35031] [chromium] Implement cancelGeolocationPermissionRequestForFrame : [Attachment 52160] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Marcus Bulach
<bulach at chromium.org>'s request for review:
Bug 35031: [chromium] Implement cancelGeolocationPermissionRequestForFrame
https://bugs.webkit.org/show_bug.cgi?id=35031

Attachment 52160: Patch
https://bugs.webkit.org/attachment.cgi?id=52160&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/src/ChromeClientImpl.cpp
> ===================================================================
> --- WebKit/chromium/src/ChromeClientImpl.cpp	(revision 56830)
> +++ WebKit/chromium/src/ChromeClientImpl.cpp	(working copy)
> @@ -707,6 +707,12 @@ void ChromeClientImpl::requestGeolocatio
>     
m_webView->client()->geolocationService()->requestPermissionForFrame(geolocatio
nService->geolocationServiceBridge()->getBridgeId(), frame->document()->url());

>  }
>  
> +void ChromeClientImpl::cancelGeolocationPermissionRequestForFrame(Frame*
frame, Geolocation* geolocation)
> +{
> +    GeolocationServiceChromium* geolocationService =
reinterpret_cast<GeolocationServiceChromium*>(geolocation->getGeolocationServic
e());

That reinterpret_cast can be a static_cast, no?  Use static_cast when there
exists an "is a" relationship between the types you are casting.  Not doing so
can cause memory errors if you ever start using multiple inheritance.