[webkit-reviews] review granted: [Bug 36754] [GTK] webkit_get_default_session() should make sure webkit_init() is called : [Attachment 51907] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 02:14:25 PDT 2010
Holger Freyther <zecke at selfish.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 36754: [GTK] webkit_get_default_session() should make sure webkit_init() is
called
https://bugs.webkit.org/show_bug.cgi?id=36754
Attachment 51907: proposed fix
https://bugs.webkit.org/attachment.cgi?id=51907&action=review
------- Additional Comments from Holger Freyther <zecke at selfish.org>
> +// Make sure the session is initialized properly when
webkit_get_default_session() is called.
> +static void test_globals_default_session()
> +{
I think you want to call g_test_bug("36754"); here. Besides that the
webkit_init call will call get_default_session and set_cache_model but that
is fine as we have an early exit in there.
More information about the webkit-reviews
mailing list