[webkit-reviews] review denied: [Bug 33416] Hook up WebGLContextAttributes to OpenGL context creation code : [Attachment 52114] revised patch : fixed the changeLog

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Zhenyao Mo
<zmo at google.com>'s request for review:
Bug 33416: Hook up WebGLContextAttributes to OpenGL context creation code
https://bugs.webkit.org/show_bug.cgi?id=33416

Attachment 52114: revised patch : fixed the changeLog
https://bugs.webkit.org/attachment.cgi?id=52114&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebGraphicsContext3D.h
...
>      // This destructor needs to be public so that using classes can destroy
instances if initialization fails.
> -    virtual ~WebGraphicsContext3D() {}
> +    virtual ~WebGraphicsContext3D();
...
> Index: WebKit/chromium/src/WebGraphicsContext3D.cpp
...
> +WebGraphicsContext3D::~WebGraphicsContext3D()
> +{
> +}

why this change?  please note that if this destructor needs to be exported
from WebKit that we'll need to add WEBKIT_API to its declaration, but I
think it would be better to leave it implemented inline in the header file.